-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warn on empty config #491
feat: warn on empty config #491
Conversation
Linting fails because of this. I don't think this is caused by my changes. |
What is causing this? I already mentioned it in the slack channel. |
Let's skip the failing test for now. We'll remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the failing test this is ready to merge. Let's skip the test as discussed.
Oh my bad, I created two separate (both different) approaches to fix the failing test here. |
48ac391
to
d3f4f03
Compare
91e1f03
to
fbbf07b
Compare
https://github.com/marionebl/commitlint/issues/107
Description
Push empty rules error to commitlint results if no rules are found.
How Has This Been Tested?
See: https://github.com/marionebl/commitlint/compare/master...escapedcat:feat/107_warn-on-empty-config?expand=1#diff-9ab1790ed00b7ca8fb5c7def7e9d2641R49
Types of changes
Checklist: