Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @commitlint/config-nx-scopes does not support [email protected] #4067

Closed
4 tasks
DavidVollmers opened this issue May 7, 2024 · 3 comments
Closed
4 tasks

Comments

@DavidVollmers
Copy link
Contributor

Steps to Reproduce

1. Upgrade nx workspace to latest version using `nx migrate latest`
2. Run `npm install`

Current Behavior

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @commitlint/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/nx
npm ERR!   dev nx@"19.0.0" from the root project
npm ERR!   nx@"19.0.0" from @nrwl/[email protected]
npm ERR!   node_modules/@nrwl/tao
npm ERR!     @nrwl/tao@"19.0.0" from [email protected]
npm ERR!   2 more (@nx/devkit, @nx/workspace)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional nx@"^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from @commitlint/[email protected]
npm ERR! node_modules/@commitlint/config-nx-scopes
npm ERR!   dev @commitlint/config-nx-scopes@"^19.3.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/nx
npm ERR!   peerOptional nx@"^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0" from @commitlint/[email protected]
npm ERR!   node_modules/@commitlint/config-nx-scopes
npm ERR!     dev @commitlint/config-nx-scopes@"^19.3.0" from the root project

Expected Behavior

The @commitlint/config-nx-scopes package version 19.3.0 should support the latest nx version.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

No response

commitlint --version

@commitlint/[email protected]

git --version

git version 2.33.1.windows.1

node --version

v20.9.0

@DavidVollmers
Copy link
Contributor Author

I would probably take this on soon. My only question is what is the desired strategy here? Do we just update the dependency to ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 or would it be smarter to set it to something like >=14.0.0? I think the latter one makes more sense for future updates of nx since it is really unlikely that the package will break.

@escapedcat
Copy link
Member

Let me try to tag @supernaut , he took care of these before.

This is the PR created by depfu btw: #4072

@DavidVollmers
Copy link
Contributor Author

This is solved with v19.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants