From 781c29a1564df427bbabf6544d6e3e2634ded0e9 Mon Sep 17 00:00:00 2001 From: Javier Collado Date: Wed, 27 Jan 2016 12:24:05 +0100 Subject: [PATCH 1/2] feat(lib): Allow semver commits Allow commits typically generated by `npm version` Closes #13 --- index.js | 3 ++- package.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index 56b1264..e6a884f 100755 --- a/index.js +++ b/index.js @@ -15,11 +15,12 @@ var fs = require('fs'); var util = require('util'); var resolve = require('path').resolve; var findup = require('findup'); +var semverRegex = require('semver-regex') var config = getConfig(); var MAX_LENGTH = config.maxSubjectLength || 100; var PATTERN = /^((?:fixup!\s*)?(\w*)(\(([\w\$\.\*/-]*)\))?\: (.*))(\n|$)/; -var IGNORED = /^WIP/; +var IGNORED = new RegExp(util.format('(^WIP)|(^%s$)', semverRegex().source)); var TYPES = config.types || ['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'chore', 'revert']; var error = function() { diff --git a/package.json b/package.json index 52c290a..8cb1249 100644 --- a/package.json +++ b/package.json @@ -67,6 +67,7 @@ } }, "dependencies": { - "findup": "0.1.5" + "findup": "0.1.5", + "semver-regex": "1.0.0" } } From a7a403e24d476f58199afa87e7eb655db30796a9 Mon Sep 17 00:00:00 2001 From: Javier Collado Date: Wed, 27 Jan 2016 12:26:36 +0100 Subject: [PATCH 2/2] test(lib): Add semver style commit test --- index.test.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/index.test.js b/index.test.js index 8cc362b..5e2b6ed 100644 --- a/index.test.js +++ b/index.test.js @@ -101,10 +101,13 @@ describe('validate-commit-msg.js', function() { expect(m.validateMessage('WIP stuff')).to.equal(VALID); }); - it('should handle undefined message"', function() { expect(m.validateMessage()).to.equal(INVALID); }); + + it('should allow semver style commits', function() { + expect(m.validateMessage('v1.0.0-alpha.1')).to.equal(VALID); + }); }); afterEach(function() {