test passed

Author: David Inga

Diff for: .eslintignore

@@ -0,0 +1,2 @@
+node_modules
+examples

Diff for: lib/auth.js

@@ -14,10 +14,10 @@ function Strategy(options = {}) {
 // Inherits from Passport Strategy
 util.inherits(Strategy, passport.Strategy);
 
-function reqParamFromQuery(paramName, request) {
+function reqParamFromQuery(paramName, req) {
   let token = null;
-  if (request.query && Object.prototype.hasOwnProperty.call(request.query, paramName)) {
-    token = request.query[paramName];
+  if (req.query && Object.prototype.hasOwnProperty.call(req.query, paramName)) {
+    token = req.query[paramName];
   }
   return token;
 }
@@ -33,42 +33,40 @@ Strategy.prototype.authenticate = function authenticate(req) {
     return self.fail(new Error('No auth token'));
   }
 
-  // Save token in session
-
-  const verified = function(err, user, info) {
+  function verified(err, user, info) {
     if (err) {
       return self.error(err);
     }
     if (!user) {
       return self.fail(info);
     }
     return self.success(user, info);
-  };
+  }
 
   try {
-    self.verify(token, verified);
-  } catch(ex) {
-    self.error(ex);
+    return self.verify(token, verified);
+  } catch (ex) {
+    return self.error(ex);
   }
 };
 
 /**
  * Verify using Control Tower gateway
  */
-Strategy.prototype.verify = function verify(token, done) {
+Strategy.prototype.verify = function verify(userToken, done) {
   request(`${this.controlTowerUrl}/auth/check-logged`)
-    .set('Authorization', `Bearer ${token}`)
+    .set('Authorization', `Bearer ${userToken}`)
     .end((err, res) => {
       if (err) {
         done(err, null, 'User unathorized');
       } else {
-        const user = Object.assign({}, res.body, { token: token });
+        const user = Object.assign({}, res.body, { token: userToken });
         done(null, user, 'User authenticated correctly');
       }
     });
 };
 
-Strategy.prototype.login = function(req, res) {
+Strategy.prototype.login = function login(req, res) {
   res.redirect(`${this.controlTowerUrl}/auth?callbackUrl=${this.callbackUrl}&token=true`);
 };