Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a UnderlineVisible and/or UnderlineActiveColor bindable property #92

Closed
fabcall opened this issue Mar 1, 2019 · 2 comments
Closed
Labels
enhancement New feature or request valid This issue/bug/feature request is valid

Comments

@fabcall
Copy link

fabcall commented Mar 1, 2019

Is your feature request related to a problem? Please describe.
As of now, one can control the color of the MaterialTextField's underline using the TintColorProperty. Any change made to this prop also affects the floating placeholder. But, sometimes, you may wish to not have a underline at all, eg. when you place a MaterialTextField inside a TextCell. I attached an example at the Additional Context. It's from an iOS app, but the Android one is equal. You can see there's a really opaque line under the textfield, but it belongs to the cell itself.

Describe the solution you'd like
Having an option to control the inactive/active color would be nice, as one could simply set it as transparent.

Describe alternatives you've considered
An alternative could be an IsUnderlineVisible property, which would control whether the line is rendered or not.

Additional context
<img src="https://is5-ssl.mzstatic.com/image/thumb/Purple128/v4/31/80/a9/3180a963-a930-3b84-57ec-49b58185c91c/mzl.bafeurhs.png/230x0w.jpg" />

@moreirawebmaster
Copy link

PR for disable underline: #93

@contrix09 contrix09 self-assigned this Mar 5, 2019
@contrix09 contrix09 added enhancement New feature or request valid This issue/bug/feature request is valid labels Mar 5, 2019
@contrix09
Copy link

You can disable the underline from showing/animating using the new property ShouldAnimateUnderline.

@contrix09 contrix09 removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request valid This issue/bug/feature request is valid
Projects
None yet
Development

No branches or pull requests

2 participants