Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Prometheus metrics #97

Closed
lukasmalkmus opened this issue Nov 13, 2017 · 7 comments
Closed

[FEATURE] Prometheus metrics #97

lukasmalkmus opened this issue Nov 13, 2017 · 7 comments

Comments

@lukasmalkmus
Copy link

lukasmalkmus commented Nov 13, 2017

I'm keeping this short: I'm pretty sure the project and its users can benefit from exporting prometheus metrics. Metrics are important in modern application deployments, especially if there are many moving parts.

I would suggest to export some basic metrics about the application itself, queues, jobs and the web server (latency, http status codes, etc.). They are also interesting for scaling Kubernetes deplyoments: See #19.

If this is desired, we can discuss it in detail and I would love to contribute a basic implementation.

@mperham
Copy link
Collaborator

mperham commented Nov 13, 2017

The INFO command provides basic metrics already but you'd have to pull them. I'm still in the process of deciding how to support various metrics standards like Prometheus and Statsd.

@lukasmalkmus
Copy link
Author

lukasmalkmus commented Dec 18, 2017

Today I hacked together a very basic exporter. It isn't very powerful, just supports a few key metrics.

@mperham
Copy link
Collaborator

mperham commented Apr 11, 2019

Faktory Pro now has Statsd support. I will add first-class Prometheus support based on customer demand.

@mperham mperham closed this as completed Apr 11, 2019
@alondahari
Copy link

@mperham Was there any work towards supporting exports to Prometheus? We would like to utilise those for alerting for our enterprise account.

@mperham
Copy link
Collaborator

mperham commented Aug 21, 2023

Not yet, you're the first to request Prometheus support.

@MrDHat
Copy link

MrDHat commented May 2, 2024

Adding my vote to support prometheus metrics!

@MRigal
Copy link

MRigal commented Jun 27, 2024

Thanks @lukasmalkmus for bringing this up and providing a first exporter. As I had problem to use your package from source as well as in a docker container, I've written a similar Python implementation: https://github.com/prospect-server/faktory-prometheus-exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants