Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding types to build [TOL-909] #6

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Conversation

aodhagan-cf
Copy link
Collaborator

Just realised when attempting to use the package that types are not exported 🙃

@aodhagan-cf aodhagan-cf requested a review from a team February 23, 2023 15:34
@@ -1,6 +1,6 @@
{
"name": "@contentful/live-preview",
"version": "1.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is not automatically doing this, must be something wrong with the setup 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhh that strange 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this plugin for updating the package.json version:
https://github.com/semantic-release/git

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already in the package.json

@aodhagan-cf aodhagan-cf merged commit 0872534 into main Feb 23, 2023
@aodhagan-cf aodhagan-cf deleted the feat/TOL-909_adding_type branch February 23, 2023 16:02
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants