fix: stop activation spinner after bundle activation in activateBundle

Author: lewisjcs

packages/contentful--app-scripts/src/activate/activate-bundle.ts

@@ -65,8 +65,6 @@ export async function activateBundle({
       currentDefinition
     );
   } catch (err: any) {
-    activationSpinner.stop();
-
     let errorData: any;
     try {
       errorData = JSON.parse(err.message);
@@ -106,6 +104,8 @@ export async function activateBundle({
       err,
       'Something went wrong activating your bundle. Make sure you used the correct definition-id.'
     );
+  } finally {
+    activationSpinner.stop();
   }
 
   console.log(`

packages/contentful--app-scripts/src/build-functions/build-functions.ts

@@ -121,8 +121,6 @@ export const resolveEsBuildConfig = (
     outdir: 'build',
     format: 'esm',
     target: 'es2022',
-    // platform: 'node',
-    // target: ['node20'],
     minify: options.minify ?? true,
     define: {
       global: 'globalThis',