-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: encode CPA response when csm alpha feature is enabled [TOL-2080] #2218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm missing tests for the new behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, no concerns
🎉 This PR is included in version 10.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This should make it easier for customers to set up Content Source Maps. Once this is merged, enabling the CSM alpha feature will encode the CPA response directly reducing the steps needed to set this up
Description
We have added a wrapper function the conditionally encodes the CPA response depending on whether the alpha feature is enabled or not
Todos
withContentSourceMaps
toincludeContentSourceMaps
NOTE:
We haven't added tests for the entry endpoint because the test entry in the space uses unsupported fields & we have realised that we currently encode them in the csm package anyway so we would have to finish the work on supporting them first before adding tests here to confirm if they work