Allow retry limit to be changed #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 69.37% 69.37%
=======================================
Files 6 6
Lines 934 934
Branches 168 168
=======================================
Hits 648 648
Misses 286 286
Continue to review full report at Codecov.
|
phoebeschmidt
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
👍 LGTM.
My only concern is how these new config options get surfaced to users (they dont usually). I know it's annoying but would you mind also making PRs to update the Readme's for the CMA and CDA sdks to include retryLimit as an option when constructing the client? 🙏
matthew-contentful
force-pushed
the
feat/import-export-timeout-retry
branch
from
636ec13
to
6e70a49
Compare
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related PR contentful/contentful-cli#175