Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rate-limit): revert rate-limit logic back to counting retries per request ID #79

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

phoebeschmidt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #79 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage    69.3%   69.23%   -0.07%     
==========================================
  Files           6        6              
  Lines         935      933       -2     
  Branches      165      167       +2     
==========================================
- Hits          648      646       -2     
  Misses        287      287
Impacted Files Coverage Δ
lib/rate-limit.js 76.05% <100%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9088f46...a013ad1. Read the comment docs.

@phoebeschmidt phoebeschmidt merged commit c3489d3 into master Jun 5, 2019
@phoebeschmidt phoebeschmidt deleted the fix/retry-logic-regression branch June 5, 2019 09:18
@Khaledgarbaya
Copy link
Contributor

🎉 This PR is included in version 6.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants