Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ratelimit retry #77

Merged
merged 1 commit into from
May 2, 2019
Merged

fix: improve ratelimit retry #77

merged 1 commit into from
May 2, 2019

Conversation

Khaledgarbaya
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #77 into master will decrease coverage by 34.24%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
- Coverage    69.1%   34.86%   -34.25%     
===========================================
  Files           6        6               
  Lines         929      935        +6     
  Branches      167      165        -2     
===========================================
- Hits          642      326      -316     
- Misses        287      609      +322
Impacted Files Coverage Δ
lib/rate-limit.js 67.44% <76.92%> (-8.16%) ⬇️
lib/utils.js 37.5% <0%> (-62.5%) ⬇️
lib/get-user-agent.js 19.81% <0%> (-55.77%) ⬇️
lib/create-http-client.js 22.79% <0%> (-47.91%) ⬇️
lib/freeze-sys.js 29.86% <0%> (-28.48%) ⬇️
lib/create-request-config.js 31.61% <0%> (-24.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f78471...8a59fdb. Read the comment docs.

@Khaledgarbaya Khaledgarbaya changed the title improve ratelimit retry fix: improve ratelimit retry May 2, 2019
@Khaledgarbaya Khaledgarbaya merged commit 56201fb into master May 2, 2019
@Khaledgarbaya Khaledgarbaya deleted the fix/retry branch May 2, 2019 11:55
@Khaledgarbaya
Copy link
Contributor Author

🎉 This PR is included in version 6.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants