Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-user-agent): user agent platform error #191

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

ruderngespra
Copy link
Contributor

@ruderngespra ruderngespra commented Aug 30, 2021

Branched off from #161 and rebased.

Attends #120.

Fix #120 - This encapsulates the `platform` from OS within that object since we use `os: false` in the package.json.
@ruderngespra ruderngespra marked this pull request as ready for review August 31, 2021 08:08
@ruderngespra ruderngespra requested review from a team and marcolink August 31, 2021 08:08
Copy link
Member

@marcolink marcolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to release this as a canary first?

@ruderngespra
Copy link
Contributor Author

Do we plan to release this as a canary first?

Yes, let's do that.

@ruderngespra ruderngespra changed the base branch from master to next August 31, 2021 12:09
@ruderngespra ruderngespra merged commit d24b2fb into next Aug 31, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

🎉 This PR is included in version 6.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released on @next label Aug 31, 2021
ruderngespra added a commit that referenced this pull request Sep 2, 2021
Fix #120 - This encapsulates the `platform` from OS within that object since we use `os: false` in the package.json.

Co-authored-by: Luiz Fonseca <[email protected]>

Co-authored-by: Luiz Fonseca <[email protected]>
@ghost ghost mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants