feat: add typescript types #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 1, 2020 14:10
anho
reviewed
Dec 1, 2020
| @@ -1,5 +1,7 @@ | |||
| import copy from 'fast-copy' | |||
| import qs from 'qs' | |||
| import type { AxiosStatic } from 'axios' | |||
There was a problem hiding this comment.
I'd recommend to hide all the Axios* names/types behind re-exported ones to make potential switches easier.
There was a problem hiding this comment.
Not sure if we need to do it now, realistically if we mostly likely switch from axios to redaxios and have exactly the same API
marcolink
approved these changes
Dec 2, 2020
TimBeyer
reviewed
Dec 2, 2020
| @@ -14,7 +15,8 @@ function deepFreeze (object) { | |||
| return Object.freeze(object) | |||
| } | |||
|
|
|||
| export default function freezeSys (obj) { | |||
| export default function freezeSys<T>(obj: T): T { | |||
There was a problem hiding this comment.
I think you could change the type to mark the sys portion as Readonly so TS is aware of the freeze, but it would be of course more of a nice to have.
There was a problem hiding this comment.
I'd rather keep it simple now to avoid unnecessary complications of types in contentful-management
TimBeyer
reviewed
Dec 2, 2020
TimBeyer
approved these changes
Dec 2, 2020
|
🎉 This PR is included in version 6.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typesfield topackage.json