feat(headers): do not overwrite the Authorization header (#75)

contentful · Mar 7, 2019 · 904791b · 904791b
1 parent 7279d73
commit 904791b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/create-http-client.js b/lib/create-http-client.js
@@ -82,7 +82,9 @@ export default function createHttpClient (axios, options) {
 
   const baseURL = options.baseURL || `${protocol}://${hostname}:${port}${config.basePath}/spaces/${space}`
 
-  config.headers['Authorization'] = 'Bearer ' + config.accessToken
+  if (!config.headers['Authorization']) {
+    config.headers['Authorization'] = 'Bearer ' + config.accessToken
+  }
 
   // Set these headers only for node because browsers don't like it when you
   // override user-agent or accept-encoding.

diff --git a/test/unit/create-http-client-test.js b/test/unit/create-http-client-test.js
@@ -82,6 +82,23 @@ test('Calls axios based on passed hostname with insecure flag', t => {
   t.end()
 })
 
+test('Calls axios based on passed headers', t => {
+  setup()
+  createHttpClient(axios, {
+    accessToken: 'clientAccessToken',
+    headers: {
+      'X-Custom-Header': 'example',
+      Authorization: 'Basic customAuth'
+    }
+  })
+
+  t.equals(axios.create.args[0][0].headers['X-Custom-Header'], 'example')
+  t.equals(axios.create.args[0][0].headers['Authorization'], 'Basic customAuth')
+
+  teardown()
+  t.end()
+})
+
 test('Calls axios with reques/response logger', t => {
   setup()
   createHttpClient(axios, {