Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for linux/arm64 #40

Open
magiconair opened this issue May 10, 2022 · 3 comments · May be fixed by #41
Open

Add support for linux/arm64 #40

magiconair opened this issue May 10, 2022 · 3 comments · May be fixed by #41

Comments

@magiconair
Copy link

magiconair commented May 10, 2022 •
edited
Loading

We are building a cluster running both linux/amd64 and linux/arm64 nodes. We run the coredns-nodecache on the nodes and need to support linux/arm64. I'll fork the repo and try to create a PR but if you have support for this somewhere already then I'd be happy to take it.
@yannh
Copy link
Collaborator

yannh commented May 10, 2022

cc @elblivion I have positive experience using goreleaser, not sure if that's something we would be interested in adding here?

@magiconair magiconair linked a pull request May 10, 2022 that will close this issue
Open
@magiconair
Copy link
Author

goreleaser would only create the different coredns binaries AFAIR but we also need base images for the amd64 and arm64 architecture and create a multi-architecture manifest so that you can just pull by name and the client will get the correct image.

@hoangminhtu-dh
Copy link

My understanding is we'd need to tweak

coredns-nodecache/Makefile

Line 2 in c637fac

docker build -t contentful-labs/coredns-nodecache .
to use the new buildx. Example: https://github.com/kubernetes/node-problem-detector/blob/9b2d0be9504e7b7c95f053af51bcad520a5b46de/Makefile#L272 (PR: https://github.com/kubernetes/node-problem-detector/pull/684/files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for linux/arm64 northvolt/coredns-nodecache
3 participants
@yannh @magiconair @hoangminhtu-dh