Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck in docker image #1722

Closed
denisz1 opened this issue Aug 8, 2023 · 2 comments
Closed

Healthcheck in docker image #1722

denisz1 opened this issue Aug 8, 2023 · 2 comments

Comments

@denisz1
Copy link

denisz1 commented Aug 8, 2023

Is your feature request related to a problem? Please describe.

Please add HEALTHCHECK as describe in here by piksel.

There was motivations in that thread showing why it is necessary even if it does not provide value to Watchtower. But it provide value to environment in general.

That issue is close, so I open this new tracking issue.

Describe the solution you'd like

He shows the best way to do it is like this:

I think it would be fine to add a command line argument to the watchtower binary that (optionally, just checks if there is another watchtower process running and then) returns 0.

Then we could add that as the HEALTHCHECK in the docker file.

This way, we still fulfill the contract of "when is the container considered healthy", despite the actual work the HEALTHCHECK command does being none.

The reasoning stated above as to why we only do that should of course be added to the docs

Describe alternatives you've considered

There is no alternative.

Additional context

No response

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Hi there! 👋🏼 As you're new to this repo, we'd like to suggest that you read our code of conduct as well as our contribution guidelines. Thanks a bunch for opening your first issue! 🙏

@denisz1
Copy link
Author

denisz1 commented Aug 8, 2023

I close this because the other one is now reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants