Skip to content

Fix bad access log#2682

Merged
traefiker merged 5 commits intotraefik:masterfrom
mmatur:improve-access-log
Jan 11, 2018
Merged

Fix bad access log#2682
traefiker merged 5 commits intotraefik:masterfrom
mmatur:improve-access-log

Conversation

@mmatur
Copy link
Member

@mmatur mmatur commented Jan 9, 2018 •
edited
Loading

What does this PR do?

This PR fix two issues:

  • bad access log when Træfik throw an error
  • missing quotes on referrer and user-agent fields

Motivation

Fixes #2649 #2565

More

  • Added/updated tests

@mmatur mmatur added this to the 1.6 milestone Jan 9, 2018
@mmatur mmatur force-pushed the improve-access-log branch 4 times, most recently from dbaaef7 to 6ccd255 Compare January 9, 2018 19:34
@mmatur mmatur force-pushed the improve-access-log branch 3 times, most recently from bb80e80 to 1683798 Compare January 10, 2018 15:09
nmengin
nmengin approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 🗞️

juliens
juliens requested changes Jan 10, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

integration/fixtures/consul/simple.toml469785378 Outdated
Copy link
Member

@juliens juliens Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this file ?

integration/fixtures/traefik_log_config.toml Outdated
Copy link
Member

@juliens juliens Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[web] is deprecated

integration/fixtures/access_log_config.toml Outdated
Copy link
Member

@juliens juliens Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[web] is deprecated

@mmatur mmatur force-pushed the improve-access-log branch from 1683798 to ed1174a Compare January 10, 2018 17:40
@mmatur mmatur force-pushed the improve-access-log branch from ed1174a to 168797e Compare January 10, 2018 17:42
ldez
ldez approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 709d508 into traefik:master Jan 11, 2018
@mmatur mmatur deleted the improve-access-log branch March 21, 2018 17:48
@sayden sayden mentioned this pull request Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@nmengin nmengin nmengin approved these changes

+1 more reviewer

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/logs area/middleware kind/bug/fix a bug fix size/L

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

Missing quotes arround the Referer field in access logs

5 participants

@mmatur @juliens @ldez @nmengin @traefiker