Fix copyUIDGID parameter inversion in Docker compat API #27379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
github-actions
bot
added
the
kind/api-change
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Docker API's copyUIDGID=true means "preserve UID/GID from archive" but Podman's internal Chown=true means "chown to container user". This caused Docker SDK clients to have files incorrectly chowned to root:root instead of preserving the archive's UID/GID. Fixes: containers#27332 Fixes: https://issues.redhat.com/browse/RUN-3643 Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
fix-copyuidguid
branch
from
2a26c50 to
2b848cc
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker API's
copyUIDGID=truemeans "preserve UID/GID from archive" but Podman's internalChown=truemeans "chown to container user". This caused Docker SDK clients to have files incorrectly chowned toroot:rootinstead of preserving the archive's UID/GID.Fixes: #27332
Fixes: https://issues.redhat.com/browse/RUN-3643
Does this PR introduce a user-facing change?