Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootless: do not segfault if the parent already died #1201

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Aug 2, 2018

Signed-off-by: Giuseppe Scrivano [email protected]

@rhatdan
Copy link
Member

rhatdan commented Aug 2, 2018

LGTM
@mheon @baude @umohnani8 @TomSweeneyRedHat PTAL

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Won't admit to the number of times I've typed in null and not nil in go code....

@mheon
Copy link
Member

mheon commented Aug 2, 2018

LGTM. Good to merge once Travis is green.

@umohnani8
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 2, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit c7b6403 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit c7b6403 with merge b286b6b...

rh-atomic-bot pushed a commit that referenced this pull request Aug 2, 2018
Closes: #1189

Signed-off-by: Giuseppe Scrivano <[email protected]>

Closes: #1201
Approved by: rhatdan
@mheon
Copy link
Member

mheon commented Aug 2, 2018

Homu seems hung
@rh-atomic-bot retry

@rhatdan
Copy link
Member

rhatdan commented Aug 2, 2018

Still seems to be hung. Merging Manually.

@rhatdan rhatdan merged commit 9f2da6f into containers:master Aug 2, 2018
@afbjorklund
Copy link
Contributor

Opened #1206 for the other part of this problem (#1189)

afbjorklund added a commit to afbjorklund/minikube that referenced this pull request Sep 22, 2018
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants