Generated "docker" script has faulty variable substitution

[siretart]

Issue Description

the generated docker script interpolates the variable $HOME when it should not

Steps to reproduce the issue

ETCDIR=/etc BINDIR=/bin envsubst < docker.in 

Describe the results you received

#!/bin/sh
[ -e /etc/containers/nodocker ] || [ -e "\${XDG_CONFIG_HOME-\/home/siretart/.config}/containers/nodocker" ] || \
echo "Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg." >&2
exec /bin/podman "$@"

Describe the results you expected

#!/bin/sh
[ -e /etc/containers/nodocker ] || [ -e "${XDG_CONFIG_HOME-${HOME}/.config}/containers/nodocker" ] || \
echo "Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg." >&2
exec /bin/podman "$@"

podman info output

not necessary

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

not necessary

Additional information

this is actually the only issue found that makes the debian package fail the reproducibilty test: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/podman.html

All other bits and pieces of podman are bit-for-bit reproducible! great work! :-)

[afbjorklund]

It is the same in Fedora package. But you probably don't get far without $XDG_CONFIG_HOME anyway?

#!/usr/bin/sh
[ -e /etc/containers/nodocker ] || [ -e "\${XDG_CONFIG_HOME-\/builddir/.config}/containers/nodocker" ] || \
echo "Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg." >&2
exec /usr/bin/podman "$@"

EDIT: The dollar is actually escaped, so it is broken there too... (Only the /etc/containers/nodocker works)

https://koji.fedoraproject.org/koji/buildinfo?buildID=2596372