fileperms: newer Go 1.13+ octal literal format

Problem: While removing cgroupsv1 code, I noticed my neovim Go config
automatically changed fileperms to the new octal format and I didn't
want that polluting my diffs.

Decision: I thought it best to switch to the new octal format in a dedicated PR.

Action:
- Cursor switched to new octal format for all fileperm ocurrences in Go
 source and test files.
- vendor/, docs/ and non-Go files were ignored.
- Reviewed manually.

Ref: https://go.dev/ref/spec#Go_1.13

Signed-off-by: Lokesh Mandvekar <[email protected]>

Author: lsm5

cmd/podman/common/build.go

@@ -249,7 +249,7 @@ func ParseBuildOpts(cmd *cobra.Command, args []string, buildOpts *BuildFlagsWrap
 	var logFile *os.File
 	if cmd.Flag("logfile").Changed {
 		var err error
-		logFile, err = os.OpenFile(buildOpts.Logfile, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0600)
+		logFile, err = os.OpenFile(buildOpts.Logfile, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0o600)
 		if err != nil {
 			return nil, err
 		}

cmd/podman/containers/commit.go

@@ -116,7 +116,7 @@ func commit(_ *cobra.Command, args []string) error {
 		return err
 	}
 	if len(iidFile) > 0 {
-		if err = os.WriteFile(iidFile, []byte(response.Id), 0644); err != nil {
+		if err = os.WriteFile(iidFile, []byte(response.Id), 0o644); err != nil {
 			return fmt.Errorf("failed to write image ID: %w", err)
 		}
 	}

cmd/podman/containers/export.go

@@ -81,7 +81,7 @@ func export(_ *cobra.Command, args []string) error {
 		}
 		// open file here with O_WRONLY since on MacOS it can fail to open /dev/stderr in read mode for example
 		// https://github.com/containers/podman/issues/16870
-		file, err := os.OpenFile(outputFile, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
+		file, err := os.OpenFile(outputFile, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0o644)
 		if err != nil {
 			return err
 		}

cmd/podman/early_init_linux.go

@@ -21,7 +21,7 @@ func setRLimits() error {
 
 func setUMask() {
 	// Be sure we can create directories with 0755 mode.
-	syscall.Umask(0022)
+	syscall.Umask(0o022)
 }
 
 func earlyInitHook() {

cmd/podman/generate/spec.go

@@ -59,7 +59,7 @@ func spec(_ *cobra.Command, args []string) error {
 	// if we are looking to print the output, do not mess it up by printing the path
 	// if we are using -v the user probably expects to pipe the output somewhere else
 	if len(opts.FileName) > 0 {
-		err = os.WriteFile(opts.FileName, report.Data, 0644)
+		err = os.WriteFile(opts.FileName, report.Data, 0o644)
 		if err != nil {
 			return err
 		}

cmd/podman/images/utils_linux.go

@@ -20,7 +20,7 @@ func setupPipe() (string, func() <-chan error, error) {
 		return "", nil, err
 	}
 	pipePath := filepath.Join(pipeDir, "saveio")
-	err = unix.Mkfifo(pipePath, 0600)
+	err = unix.Mkfifo(pipePath, 0o600)
 	if err != nil {
 		if e := os.RemoveAll(pipeDir); e != nil {
 			logrus.Errorf("Removing named pipe: %q", e)

cmd/podman/kube/generate.go

@@ -109,7 +109,7 @@ func generateKube(cmd *cobra.Command, args []string) error {
 		if err := fileutils.Exists(generateFile); err == nil {
 			return fmt.Errorf("cannot write to %q; file exists", generateFile)
 		}
-		if err := os.WriteFile(generateFile, content, 0644); err != nil {
+		if err := os.WriteFile(generateFile, content, 0o644); err != nil {
 			return fmt.Errorf("cannot write to %q: %w", generateFile, err)
 		}
 		return nil

cmd/podman/manifest/push.go

@@ -170,7 +170,7 @@ func push(cmd *cobra.Command, args []string) error {
 		return err
 	}
 	if manifestPushOpts.DigestFile != "" {
-		if err := os.WriteFile(manifestPushOpts.DigestFile, []byte(digest), 0644); err != nil {
+		if err := os.WriteFile(manifestPushOpts.DigestFile, []byte(digest), 0o644); err != nil {
 			return err
 		}
 	}

cmd/podman/system/service.go

@@ -111,7 +111,7 @@ func service(cmd *cobra.Command, args []string) error {
 			if err := syscall.Unlink(uri.Path); err != nil && !os.IsNotExist(err) {
 				return err
 			}
-			mask := syscall.Umask(0177)
+			mask := syscall.Umask(0o177)
 			defer syscall.Umask(mask)
 		}
 	}
@@ -162,12 +162,12 @@ func resolveAPIURI(uri []string) (string, error) {
 
 		socketName := "podman.sock"
 		socketPath := filepath.Join(xdg, "podman", socketName)
-		if err := os.MkdirAll(filepath.Dir(socketPath), 0700); err != nil {
+		if err := os.MkdirAll(filepath.Dir(socketPath), 0o700); err != nil {
 			return "", err
 		}
 		return "unix://" + socketPath, nil
 	default:
-		if err := os.MkdirAll(filepath.Dir(registry.DefaultRootAPIPath), 0700); err != nil {
+		if err := os.MkdirAll(filepath.Dir(registry.DefaultRootAPIPath), 0o700); err != nil {
 			return "", err
 		}
 		return registry.DefaultRootAPIAddress, nil

cmd/quadlet/main.go

@@ -51,7 +51,7 @@ func logToKmsg(s string) bool {
 	}
 
 	if kmsgFile == nil {
-		f, err := os.OpenFile("/dev/kmsg", os.O_WRONLY, 0644)
+		f, err := os.OpenFile("/dev/kmsg", os.O_WRONLY, 0o644)
 		if err != nil {
 			noKmsg = true
 			return false