Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.37] Bump to Buildah v1.37.3 #5749

Conversation

TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat commented Sep 20, 2024

Bump to v1.37.3 in preparation of Podman v5.2.3

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Bump to v1.37.3 in preparation of Podman v5.3

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Sep 20, 2024
@nalind
Copy link
Member

nalind commented Sep 20, 2024

Is this for a podman 5.3 or a podman 5.2.3?

@TomSweeneyRedHat
Copy link
Member Author

Podman 5.2.3 at the moment. If we go to Podman 5.3 later this fall, I'd plan a Buildah Bump to v1.38

@TomSweeneyRedHat
Copy link
Member Author

and I'll change my description....

@TomSweeneyRedHat
Copy link
Member Author

OK, I'm going to use the merge bat on this one.
/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@TomSweeneyRedHat: you cannot LGTM your own PR.

In response to this:

OK, I'm going to use the merge bat on this one.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TomSweeneyRedHat
Copy link
Member Author

Well, I guess I can't use the merge bat. @rhatdan @mheon @Luap99, could someone give this a final lgtm please.

@mheon
Copy link
Member

mheon commented Sep 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 138ca25 into containers:release-1.37 Sep 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants