Cleanup Socket and Pidfile on exit #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were previously left intact, even when exiting gracefully. As the daemon also fails if the socket already exists, it became the caller's responsibilityto check for and cleanup old socket files when performing graceful / deliberate restarts. Signed-off-by: Emily Shepherd <[email protected]>
EmilyShepherd
force-pushed
the
cleanup-socket-on-exit
branch
from
d7b31b1
to
f89a005
Compare
EmilyShepherd
added a commit
to EmilyShepherd/kiOS
that referenced
this pull request
Sep 6, 2022
Currently the script has to clean this up manually in case the container has retarted. As this has been submitted as a [patch upstream][upstream] it makes more sense to include that patch here too so we can phase out this manual extra step in the entrypoint. [upstream]: containernetworking/plugins#768
|
/lgtm |
mccv1r0
approved these changes
Sep 6, 2022
|
/lgtm |
MikeZappa87
approved these changes
Sep 12, 2022
|
LGTM too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously left intact, even when exiting gracefully. As the
daemon also fails if the socket already exists, it became the caller's
responsibilityto check for and cleanup old socket files when performing
graceful / deliberate restarts.
This fixes #760