Replace arping package with arp_notify #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeZappa87
changed the title
this replaces the arping package with the linux arp_notify feature. Resolves: containernetworking#588 Signed-off-by: Michael Zappa <[email protected]>
MikeZappa87
force-pushed
the
issue/588/removegArp
branch
from
e093eeb
to
5d073d6
Compare
mccv1r0
reviewed
Jan 7, 2022
plugins/main/ptp/ptp.go
Outdated
| contVeth, err := net.InterfaceByName(ifName) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to look up %q: %v", ifName, err) | ||
| } | ||
|
|
||
| _, _ = sysctl.Sysctl(fmt.Sprintf("net/ipv4/conf/%s/arp_notify", ifName), "1") |
There was a problem hiding this comment.
It probably won't hurt anything (Linux should do the "right thing" ), but I don't think we need garp on a point to point link.
There was a problem hiding this comment.
I can remove it, I was just keeping with the previous behavior? To state the behavior right now is once the container veth is set to up is that you see an arp announcement frame
There was a problem hiding this comment.
@mccv1r0 I have removed the arp notify setting
Signed-off-by: Michael Zappa <[email protected]>
MikeZappa87
force-pushed
the
issue/588/removegArp
branch
from
4e87328
to
7a55617
Compare
|
looks good to me, thanks! |
matthewdupre
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the arping package with the linux arp_notify feature.
Each plugin with tested using the cnitool and wireshark. Each one generated the appropriate arp announcement. If you need pictures of this I can supply them.
Resolves: #588
This might also resolve: #569