dhcp: Add priority option to dhcp. #1091
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisongmin
force-pushed
the
add-priority-option-to-dhcp
branch
from
a1cecda
to
7c17f87
Compare
LionelJouin
approved these changes
Sep 16, 2024
lisongmin
force-pushed
the
add-priority-option-to-dhcp
branch
from
7c17f87
to
4afafa5
Compare
Currently, we can not set the metric of routes in dhcp. It's ok if there is only a network interface. But if there are multiple network interfaces, and both have a default route, We need to set the metric of the route to make the traffic go through the correct network interface. For host-local and static, we can set the metric with the route.priority option. But there is no such option for dhcp. Signed-off-by: Songmin Li <[email protected]>
lisongmin
force-pushed
the
add-priority-option-to-dhcp
branch
from
4afafa5
to
442e8bb
Compare
squeed
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can not set the metric of routes in dhcp. It's ok if there is only a network interface.
But if there are multiple network interfaces, and both have a default route, We need to set the metric of the route to make the traffic go through the correct network interface.
For host-local and static, we can set the metric with the route.priority option. But there is no such option for dhcp.