ip: include peer name in error message #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiwen-zhao
approved these changes
Apr 26, 2024
qiutongs
approved these changes
Apr 26, 2024
henry118
reviewed
Apr 26, 2024
If makeVeth fails as a peer exists, the existing peer name should be included in the error message. Signed-off-by: Samuel Karp <[email protected]>
samuelkarp
force-pushed
the
log-peer-veth-failure
branch
from
44814e7
to
eb49a03
Compare
henry118
approved these changes
Apr 26, 2024
|
/lgtm |
s1061123
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If makeVeth fails as a peer exists, the existing peer name should be included in the error message.