Test rework, part 3 #3464
Open
Test rework, part 3 #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
qa-tooling-fixes
branch
from
b7d49c6
to
1b7190c
Compare
apostasie
force-pushed
the
qa-tooling-fixes
branch
from
1b7190c
to
a1224a3
Compare
apostasie
commented
Sep 26, 2024
| @@ -56,54 +56,58 @@ func TestVolumePrune(t *testing.T) { | |||
| } | |||
|
|
|||
| // This set must be marked as private, since we cannot prune without interacting with other tests. | |||
| testGroup := &test.Group{ | |||
There was a problem hiding this comment.
This pattern does not work here, as the Group will run in Parallel with other tests, breaking things for Docker.
It works with nerdctl because we are making the subtests pivate - for Docker, the subtests disable parallel, but since the parent stays parallel, it blows up.
Changing to a Test parent instead of a group, and disabling parallel on the subtests.
apostasie
force-pushed
the
qa-tooling-fixes
branch
2 times, most recently
from
28c0e5f
to
3811ad6
Compare
|
@AkihiroSuda this is ready - to be merged after #3455 |
|
@AkihiroSuda let me rebase this so we get a clean view (and might amend something). |
As we make progress rewriting tests, the new tooling needs to adapt. In a shell, this is: - introducing (more) `Requirements`, with a better API - update documentation - fix some t.Helper calls - fix broken stdin implementation - do cleanup custom namespaces properly - change hashing function - disable "private" implying custom data root which is more trouble than is worth - minor cleanups Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
qa-tooling-fixes
branch
from
3811ad6
to
2339dc5
Compare
|
Hitting 429 with Docker Hub :-( Otherwise, this is now rebased and ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3455
Notably: