Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRIORITY] Improve tests debugging output #3188

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

apostasie
Copy link
Contributor

This is a small quality of life improvement to ease debugging of tests.

When commands are unexpectedly failing, output .String() which includes the actual command and the exit code instead of .Combined() which only shows stdout+stderr.

@apostasie
Copy link
Contributor Author

Failure is unrelated - TestTailFollowRotateLogs - which should get better with the band aid once #3178 gets merged.

@AkihiroSuda PTAL at your convenience.

Thanks.

@apostasie apostasie changed the title Improve tests debugging output [PRIORITY] Improve tests debugging output Jul 5, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 5, 2024
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Jul 5, 2024
@AkihiroSuda AkihiroSuda merged commit 64b9f76 into containerd:main Jul 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants