Fix IPFS container start routine #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
dev-ci-ipfs
branch
4 times, most recently
from
73ea2cb
to
3e44585
Compare
Signed-off-by: apostasie <[email protected]>
apostasie
changed the title
apostasie
changed the title
ktock
reviewed
Jul 8, 2024
|
|
||
| name := testutil.Identifier(base.T) | ||
| // listen on 0.0.0.0 to enable 127.0.0.1 | ||
| listenIP := net.ParseIP("0.0.0.0") |
There was a problem hiding this comment.
Then it will not allow access using (non-localhost) host-ip, reducing possible test scope (comment is slightly misleading, originating from previous code in the registry start function).
|
Thanks a lot @ktock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestIPFSAddress and TestIPFSComposeUp have been failing regularly on the CI (with a rather long timeout).
Furthermore, the initialization code was using static ports and container name, making it impossible to parallelize.
This PR rewrites the initialization code of the IPFS registry container after the regular registry container start method - giving guarantees that there is no port or name collision, a sensible timeout in case of failure, an actual test to verify the registry is up and running.
It also removes the unnecessary testing of
detached-ns(apparently triggering failures with rootlesskit 1).CI is green on push (except for 1 unrelated failure involving systemctl that we have seen somewhere else).
Along with the other changes from today, this PR should increase CI reliability quite a bit.
PTAL at your convenience @AkihiroSuda @ktock .
Of course would love to see this in ASAP as failing CI has been a massive PITA, but lmk evidently if there is anything you would like tweaked.
Cheers.