Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Integrate with minikube. #462

Closed
Random-Liu opened this issue Dec 2, 2017 · 21 comments
Closed

Integrate with minikube. #462

Random-Liu opened this issue Dec 2, 2017 · 21 comments
Assignees

Comments

@Random-Liu
Copy link
Member

We should integrate with minikube to make it easier for people to try this out.

@Random-Liu Random-Liu added this to the v1.0.0-rc.0 milestone Dec 12, 2017
@yanxuean
Copy link
Member

/assign

@AkihiroSuda
Copy link
Member

@yanxuean @Random-Liu
Any update? 😃

@Random-Liu
Copy link
Member Author

Random-Liu commented Feb 20, 2018

@AkihiroSuda We punt this for now, because after CRI support is merged into containerd, this will be much simpler. We want to wait for that to happen first. :)

@Random-Liu
Copy link
Member Author

Punt this to next release.

This will be much easier after we have a containerd release which has CRI built in.

@Random-Liu Random-Liu removed this from the v1.0.0-rc.0 milestone Mar 14, 2018
@Random-Liu Random-Liu added this to the next-candidate milestone Apr 13, 2018
@yanxuean
Copy link
Member

@Random-Liu I want to know which containerd version minikube should base on.
The containerd must be the version after merging #851. and must also be release version.

@Random-Liu
Copy link
Member Author

Random-Liu commented Jul 17, 2018

@yanxuean Let's do in containerd 1.2 (hopefully in August). I'll cherrypick #851 to v1.11.

@yanxuean
Copy link
Member

ok

@yanxuean
Copy link
Member

yanxuean commented Aug 2, 2018

I have implemented minikube for supporting containerd. It base on containerd v1.1.2. The minikube need a containerd release version which must merge #851 of cri.
I don't know what the due day of containerd 1.2 is. Can we merge #851 to containerd v1.1.3?

@Random-Liu
Copy link
Member Author

@yanxuean I'm fine with that to unblock the minikube integration effort.

/cc @containerd/containerd-maintainers

@yanxuean
Copy link
Member

yanxuean commented Aug 2, 2018

fixed by kubernetes/minikube#3040

@yanxuean
Copy link
Member

yanxuean commented Aug 3, 2018

I have implemented minikube for supporting containerd. It base on containerd v1.1.2. The minikube need a containerd release version which must merge #851 of cri.
I don't know what the due day of containerd 1.2 is. Can we merge #851 to containerd v1.1.3?

@crosbymichael @dmcgowan @stevvooe Any question?

@crosbymichael
Copy link
Member

@dmcgowan @Random-Liu do we have any other changes that would be in a 1.1.3?

@Random-Liu
Copy link
Member Author

@crosbymichael That is the only one. :)

@yanxuean
Copy link
Member

yanxuean commented Aug 22, 2018

The pr for supporting containerd have merged. We will be able to use containerd in minikube v.0.28.3.
kubernetes/minikube#3040
It is time to close this issue.

@Random-Liu
Copy link
Member Author

Random-Liu commented Aug 22, 2018

@yanxuean Thanks a lot for adding the support! https://github.com/containerd/containerd/releases/tag/v1.1.3 is available. You may want to update the minikube side correspondingly.

Sorry for the delay, keep distracted by something else. :P

@Random-Liu
Copy link
Member Author

@yanxuean Ha, I see you are using 1.2.0-beta. That also works. :)

@yanxuean
Copy link
Member

Yeah, The 1.2.0-beta is better.

@Random-Liu
Copy link
Member Author

minikube v0.29.0 is released with containerd support!

https://github.com/kubernetes/minikube/blob/v0.29.0/CHANGELOG.md

Time to close this issue now! @yanxuean Thanks a lot for working on this!

@yanxuean
Copy link
Member

a little pity, It is only based on a beta version.
I will update the version after the official v1.2.0 is released.

@Random-Liu
Copy link
Member Author

@yanxuean I don't have a machine with VirtualBox. Have you tried the containerd support in minikube yourself? It should work, right?

@yanxuean
Copy link
Member

Yes, I installed virtualbox on my ubuntu16.04 and try it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants