Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize absolute path spec #84

Open
AkihiroSuda opened this issue Jun 13, 2017 · 7 comments
Open

standardize absolute path spec #84

AkihiroSuda opened this issue Jun 13, 2017 · 7 comments

Comments

@AkihiroSuda
Copy link
Member

#82 (comment)

  • should we use / separator on both Unix and Windows?
  • "absolute path" does not contain drive letter (C:), right?
@AkihiroSuda
Copy link
Member Author

ptal @dmcgowan @stevvooe

@stevvooe
Copy link
Member

@AkihiroSuda I am not sure. What will work for windows?

@AkihiroSuda
Copy link
Member Author

So, a manifest will contain paths like /Program Files/Foo/Bar.
When it is applied on C:, the path will be treated as C:\Program Files\Foo\Bar

@stevvooe
Copy link
Member

For manifests, they usually target a single platform, so having OS specific paths seems fine, which means we can avoid the conversion.

@dmcgowan
Copy link
Member

@AkihiroSuda do you know if \Program Files\Foo\Bar is considered a valid absolute path on Windows?

The advantage I see of using / for both Windows and Linux is that some content may not target a single platform, making it the responsibility of the unpacker to correctly interpret and convert the separator. As soon as the unpacker is doing some interpretation, it is allowing multiple forms for the same content which is against the design goals of continuity.

@stevvooe
Copy link
Member

@tonistiigi PTAL

I think we should probably standardize on unix-style paths. In general, the manifests should be relocatable.

@stevvooe
Copy link
Member

stevvooe commented Feb 2, 2018

@AkihiroSuda Are we good on this? What are the next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants