Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to explicitly specify extraneous dependencies in Cargo.toml #96

Closed
maksyms opened this issue Jul 26, 2020 · 2 comments · Fixed by #97
Closed

Need to explicitly specify extraneous dependencies in Cargo.toml #96

maksyms opened this issue Jul 26, 2020 · 2 comments · Fixed by #97

Comments

@maksyms
Copy link

maksyms commented Jul 26, 2020

I'm trying to build a new project using amadeus. I've copy/pasted the first example from README.md and added the following into Cargo.toml:

[dependencies]
amadeus = { version = "0.3.5", features = ["aws", "parquet"] }
tokio = "0.2.22"

The project fails to build, complaining that it cannot find amadeus_core, amadeus_types, amadeus_parquet.

The only way I could compile the project is if I explicitly list the extraneous dependencies:

[dependencies]
amadeus = { version = "0.3.5", features = ["aws", "parquet"] }
tokio = "0.2.22"
# I don't understand why these need to be explicit, rather than features above
amadeus-core = "0.3.5"
amadeus-types = "0.3.5"
amadeus-parquet = "0.3.5"

I'd like to think that amadeus package itself would include at least core and types, as well as when the extra feature like parquet is specified, it would bring in amadeus_parquet. What am I missing? Is this a bug?

@alecmocatta
Copy link
Member

Oh dear that's embarassing. Silly oversight that is fixed in #97. Thanks for the heads up @maksyms! v0.3.6 with the fix will be published shortly.

@maksyms
Copy link
Author

maksyms commented Jul 26, 2020

No worries, thanks for implementing a fix so quickly, @alecmocatta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants