Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskParallelExec does not honor current working directory as set by the commands it is running. #549

Open
brad-jones opened this issue Mar 22, 2017 · 1 comment

Comments

@brad-jones
Copy link

Steps to reproduce

$this->taskParallelExec()
    ->process($this->taskGitStack()->dir('/repo1')->checkout('develop')->pull())
    ->process($this->taskGitStack()->dir('/repo2')->checkout('develop')->pull())
    ->process($this->taskGitStack()->dir('/repo3')->checkout('develop')->pull())
->run();

Expected behavior

I expect that the git commands are run inside of /repo1, /repo2 & /repo3

Actual behavior

The current working directory is not changed and thus all 3 commands run in the same folder.

@pretzlaw
Copy link

Hint: This is due to vendor/consolidation/robo/src/Common/CommandReceiver.php:[email protected]
or \Robo\Common\CommandReceiver::receiveCommand which could prepend a cd $dir; ...

But also needs to take the other public methods in advance (e.g. checkout).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants