Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused method \Robo\Collection\Collection::addIterable() #466

Open
Sweetchuck opened this issue Oct 15, 2016 · 2 comments
Open

Unused method \Robo\Collection\Collection::addIterable() #466

Sweetchuck opened this issue Oct 15, 2016 · 2 comments

Comments

@Sweetchuck
Copy link
Contributor

I think the \Robo\Collection\Collection::addIterable() method is never been called.
And if it was get called it would throw an exception because the class IterationTask is not exists (at least I haven't found it)

https://github.com/consolidation/Robo/blob/1908cec67c6278d6d21535f14ca403cc860d4518/src/Collection/Collection.php#L79

@ephrin
Copy link

ephrin commented Jan 30, 2018

Up. Tried to add iterable to a collection and got the Fatal of not found class.

@szepeviktor
Copy link
Contributor

@phpstan confirms this

 ------ -------------------------------------------------------------
  Line   src/Collection/Collection.php
 ------ -------------------------------------------------------------
  111    Instantiated class Robo\Collection\IterationTask not found.
 ------ -------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants