Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification: remove the ability to contribute collateral at subnet creation #1142

Open
Tracked by #1099
raulk opened this issue Sep 23, 2024 · 3 comments
Open
Tracked by #1099

Comments

@raulk
Copy link
Contributor

raulk commented Sep 23, 2024

Currently, if value is sent when registering a new subnet, we record it as collateral contributed by the creator, who will now be enlisted as a validator in the network. While this might be useful in some situations, it can be achieved by performing both actions separately, in an atomic manner if needed, either through a Multicall contract or through a dedicated utility smart contract.

In other words, this feature is actually an aggregate of two other features, and therefore my view is that it can be dropped from the base protocol/mechanics in order to reduce complexity. As far as I know, it is not being actively used by any adopter at the current time. And this work #1130 was forced to add extra complexity to sustain this feature as we added a new collateral asset kind.


We can apply the same simplification to circulating supply -- I would just drop this as a subnet creation parameter.

@cryptoAtwill
Copy link
Contributor

cryptoAtwill commented Sep 25, 2024

@raulk are you referring to this method?

When the subnet is registered, it does not forward the collateral? Or actually break it into two separate calls?

@raulk
Copy link
Contributor Author

raulk commented Sep 25, 2024

@raulk
Copy link
Contributor Author

raulk commented Sep 25, 2024

@cryptoAtwill I'm referring to the whole flow, which includes that method, but also stuff in LibSubnetActor and other places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants