This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Support wrapped cross-net message delivery #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Overall LGTM. But we should really migrate the unit tests from the builtin-actors fork here ASAP before we keep adding new stuff to the actor.
adlrocha
reviewed
Nov 14, 2022
sergefdrv
force-pushed
the
wrapped-cross-msg
branch
from
c3fbc75
to
362090d
Compare
sergefdrv
force-pushed
the
wrapped-cross-msg
branch
from
362090d
to
ae490f1
Compare
|
Summary of changes:
|
adlrocha
approved these changes
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request adds support for opt-in wrapped cross-net message delivery. The new delivery method allows the destination actor examine original cross-net message as passed to
ApplyMessagemethod of the IPC gateway actor, i.e. to determine the full IPC address of the message's source actor.Tests
Issues