Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra characters in path or mbtiles names do not load and create extra files on host #96

Open
brendan-ward opened this issue Feb 14, 2020 · 1 comment
Assignees
Labels

Comments

@brendan-ward
Copy link
Collaborator

On MacOS:

Given a tileset named tileset with extra chars ();?\Å.mbtiles:

  • fails to load, complains about missing tiles
  • creates a file tileset with extra chars ();? on disk

Expected behavior:

  • raise error on opening file if path is not valid for sqlite driver
  • do not create any files on disk in case of failure to open path
@brendan-ward brendan-ward self-assigned this Feb 14, 2020
@brendan-ward
Copy link
Collaborator Author

There are characters that have special meaning for how we open the mbtiles file using the sqlite driver, such as ?. These may be valid paths but break the driver.

Best solution is likely to screen for known special characters and refuse to load these mbtiles files or paths.

/cc @asmyasnikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant