Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of crt-terminal #137

Closed
smaye81 opened this issue Feb 1, 2024 · 0 comments · Fixed by #209
Closed

Refactor usage of crt-terminal #137

smaye81 opened this issue Feb 1, 2024 · 0 comments · Fixed by #209

Comments

@smaye81
Copy link
Member

smaye81 commented Feb 1, 2024

Our usage of crt-terminal to display a terminal in our docs is causing some issues with upgrading Docusaurus.

Dependabot has been trying to update our usage of Docusaurus to v3.x for a few months now but we can't (unless we want to see peer dependency warnings) because Docusaurus added peerDependencies constraints for React v18 and above (PR).

However we can't update to React v18 yet because of our usage of crt-terminal, which has a peerDependencies constraint of React v17 (source).

We should investigate removing the complexity of this terminal feature in favor some homegrown JS and CSS. Once that is complete, we can then upgrade Docusaurus to 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant