Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: client often reports "unknown" code instead of a code based on HTTP status #744

Closed
jhump opened this issue May 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jhump
Copy link
Member

jhump commented May 28, 2024

If the server response includes a malformed or incomplete error JSON, the client will report an unknown error to the application layer. In particular, this happens if the code property is invalid or missing or if there are any type mismatches (for example, if the response includes something other than a string for the message property).

This contrasts with the spec (in the Unary-Response section):

When reading data from the wire, client implementations must use the HTTP-to-Connect mapping to infer a Connect error code if Bare-Message is missing or malformed.

Found by conformance tests in v1.15.0.

@jhump jhump added the bug Something isn't working label May 28, 2024
@jhump
Copy link
Member Author

jhump commented May 28, 2024

This bug was fixed by #702, and the fix was released in v1.16.0.

@jhump jhump closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant