-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig with AbstractKafkaSchemaSerDeConfig #336
Comments
I'm addressing this as part of some changes for running the microservices against cloud |
@rspurgeon is this GH issue resolved by https://github.com/confluentinc/kafka-streams-examples/pull/346/files ? If so, can you please mark Closed? |
@ybyzek I wasn't able to get this resolved across the entire repo, so I left this issue open. |
@rspurgeon Are you planning to resolve this across the entire repo? If not, you can unassign yourself from the issue. |
@ybyzek I don't mind picking this up and I can see deprecated warning at 34 different places - for entire repo. Let me know if I can and also the version to push to(6.0.1-post?) Thanks. |
@saurabh-slacklife -- that would be 🆒 , thanks! At this time, |
Acknowledged. |
There are certain more Java related deprecated warnings:
Not sure if you would like these to be tracked and fixed under this bug. Thanks |
@saurabh-slacklife IMO this is up to you to define scope, either:
|
@ybyzek Cool, I'll update the scope and make another commit tomorrow morning. |
@saurabh-slacklife -- it's also ok we we do multiple smaller PRs -- easier to review and quicker to merge. So maybe just address the simple comment I left on the PR, and do a follow up PR for the other required changes. Thanks. |
@mjsax I'm also in favour of multiple PRs. Just made the commit with your review comments. |
What is the status of this ticket? |
This can be closed now, the # mentioned in description and in comments are were handled. I don't have permission to make any modifications. |
Thanks for your help to fix this issue @saurabh-slacklife! |
Warning during compile:
Resolve: use new class: https://github.com/confluentinc/schema-registry/blob/5.5.0-post/schema-serializer/src/main/java/io/confluent/kafka/serializers/AbstractKafkaSchemaSerDeConfig.java
The text was updated successfully, but these errors were encountered: