Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioner classes misuse PartitionerConfig #66

Closed
dcsobral opened this issue May 16, 2018 · 2 comments
Closed

Partitioner classes misuse PartitionerConfig #66

dcsobral opened this issue May 16, 2018 · 2 comments

Comments

@dcsobral
Copy link

The classes extending Partitioner misuse PartitionerConfig as a simple storage for configuration key constants, which prevents it from being extended by third parties in a way that requires other configuration parameters.

Because of the way it is currently used, DataWriter in kafka-connect-hdfs (and, presumably other users) need to provide the "parsed" configuration, which, for example, handles conversion of numeric values into Long. Parsed configurations, however, do not include unknown keys, and there's no way of "injecting" keys.

Instead, all of the classes extending Partitioner should instantiate a PartitionerConfig from the properties received, and get their properties through it, so that unfiltered properties can be used to instantiate those classes.

@dcsobral
Copy link
Author

Looks like I reported this twice., as I missed this ticket. It's also reported as #75 .

@kkonstantine
Copy link
Member

I can confirm the duplication of the tickets atm :)
Closing this one as duplicate, as you mention, and will move the discussion to #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants