You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The classes extending Partitioner misuse PartitionerConfig as a simple storage for configuration key constants, which prevents it from being extended by third parties in a way that requires other configuration parameters.
Because of the way it is currently used, DataWriter in kafka-connect-hdfs (and, presumably other users) need to provide the "parsed" configuration, which, for example, handles conversion of numeric values into Long. Parsed configurations, however, do not include unknown keys, and there's no way of "injecting" keys.
Instead, all of the classes extending Partitioner should instantiate a PartitionerConfig from the properties received, and get their properties through it, so that unfiltered properties can be used to instantiate those classes.
The text was updated successfully, but these errors were encountered:
The classes extending
Partitioner
misusePartitionerConfig
as a simple storage for configuration key constants, which prevents it from being extended by third parties in a way that requires other configuration parameters.Because of the way it is currently used,
DataWriter
in kafka-connect-hdfs (and, presumably other users) need to provide the "parsed" configuration, which, for example, handles conversion of numeric values intoLong
. Parsed configurations, however, do not include unknown keys, and there's no way of "injecting" keys.Instead, all of the classes extending
Partitioner
should instantiate aPartitionerConfig
from the properties received, and get their properties through it, so that unfiltered properties can be used to instantiate those classes.The text was updated successfully, but these errors were encountered: