Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason why encodePartition in partitioners classes are never tested? #258

Open
mason opened this issue Nov 25, 2017 · 1 comment

Comments

@mason
Copy link

mason commented Nov 25, 2017

There are two methods, encodePartition and generatePartitionedPath. generatePartitionedPath takes the result of encodedPartition() and does some extra decoration on it. generatePartitionedPath is tested but the meat of the partitioner class(encodePartition) is not. Any idea why? The only thing I can see is that it deals with time and unit testing based on time when timezones and milliseconds are involved can be tricky.

example:

String path = partitioner.generatePartitionedPath("topic", encodedPartition);

@OneCricketeer
Copy link

Unit tests for those methods are located in the parent project kafka-connect-storage-common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants