Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a var for ANSIBLE_MERGE_BEHAVIOUR=merge #1348

Open
timetravlr opened this issue Feb 23, 2023 · 3 comments
Open

Add a var for ANSIBLE_MERGE_BEHAVIOUR=merge #1348

timetravlr opened this issue Feb 23, 2023 · 3 comments

Comments

@timetravlr
Copy link

We would like to have this be available as a variable to add to group_vars so it doesn't require doing this:

ANSIBLE_HASH_BEHAVIOUR=merge ansible-playbook -i inventories/site.yml confluent.platform.all --tags kafka_broker -l site-kafkatest-01 --skip-tags validate_hash_merge

cp-ansible/roles/common/tasks/main.yml requires this to be set in ansible.cfg or it fails.

- name: Confirm Hash Merging Enabled
  assert:
    that: lookup('config', 'DEFAULT_HASH_BEHAVIOUR') == 'merge'
    fail_msg: "Hash Merging must be enabled in ansible.cfg"
  tags:
    - validate
    - validate_hash_merge

We use a central repo and we cannot have hash behaviour = merge set globally in ansible.cfg, or it will cause problems. It is difficult to only set this for one of our collections or repos. I know other issues have been reported on this in the past.

@jceddy
Copy link

jceddy commented Sep 26, 2023

Also, I believe DEFAULT_HASH_BEHAVIOUR is deprecated as of 2.13...

@erikgb
Copy link
Contributor

erikgb commented Sep 26, 2023

This issue is a duplicate of #474, and I think changing this would be a huge task in cp-ansible. That's why I marked the other issue as an "epic" back then.

But I think there is a new team at Confluent maintaining this project now. Maybe @mansisinha or @rrbadiani could take a look and/or forward the request to a product owner in Confluent?

@mansisinha
Copy link
Member

@prabhamanepalli please have a look. We can analyse this more and include in our 2024 FF roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants