Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework RVPS store config #629

Closed
fitzthum opened this issue Dec 13, 2024 · 1 comment · Fixed by #633
Closed

Rework RVPS store config #629

fitzthum opened this issue Dec 13, 2024 · 1 comment · Fixed by #633

Comments

@fitzthum
Copy link
Member

fitzthum commented Dec 13, 2024

The RVPS config currently looks like this

pub struct Config {
    #[serde(default = "default_store_type")]
    pub store_type: String,

    #[serde(default = "default_store_config")]
    pub store_config: Value,
}

This doesn't really match how we've recently been creating configs inside of an enum and have store_config as an opaque JSON value doesn't seem ideal.

We should probably update this to have an enum containing a config, like we've started doing elsewhere in Trustee.

@fitzthum
Copy link
Member Author

I have a pending PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant