Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: set MINIFORGE_HOME: C:\Miniforge #286

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MNT: set MINIFORGE_HOME: C:\Miniforge #286

wants to merge 3 commits into from

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Oct 3, 2024 •
edited by jaimergp
Loading

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #285.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #285

From @jaimergp:

Hey, we are optimizing the provisioning overheads on Windows (download Miniforge, install dependencies, etc), and we will change the default installation path from C:\Miniforge to D:\Miniforge. This will reduce the installation times significantly. We are submitting this PR here because this feedstock was redefining CONDA_BLD_PATH to the C: drive. In that case, we do not want to move Miniforge to C:; we want both paths to be in the same drive! This should not create new builds, just protect against the upcoming change in conda-smithy, once rerendered.

More information at conda-forge/conda-smithy#2076

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Oct 3, 2024
Open
@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review October 3, 2024 17:00
@jaimergp jaimergp changed the title MNT: rerender MNT: set MINIFORGE_HOME: C:\Miniforge Oct 3, 2024
@jaimergp jaimergp mentioned this pull request Oct 3, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari Awaiting requested review from h-vetinari h-vetinari is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please rerender
2 participants
@conda-forge-admin @jaimergp