Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 missing pypy builds for 1.7.0 #173

Closed
h-vetinari opened this issue Jul 1, 2021 · 15 comments · Fixed by #176 or #182
Closed

3 missing pypy builds for 1.7.0 #173

h-vetinari opened this issue Jul 1, 2021 · 15 comments · Fixed by #176 or #182

Comments

@h-vetinari
Copy link
Member

h-vetinari commented Jul 1, 2021

See discussion in #169, culminating in this comment:

That means 1.7.0 has now been built for all but the following three variants:

  • pypy37 on linux / x64
  • pypy37 on linux / ppc
  • pypy37 on osx / x64
@mattip
Copy link
Contributor

mattip commented Jul 7, 2021

I think the PyPy crash is due to a huge stack allocation when entering a function, cython/cython#4272. I don't understand what the difference is between CPython and PyPy.

@h-vetinari
Copy link
Member Author

The PPC build will need some encouragement (=restarts), keeping this open until then.

@mattip
Copy link
Contributor

mattip commented Jul 19, 2021

I think windows64 pypy migration is missing as well?

@h-vetinari
Copy link
Member Author

Yes indeed, but I wasn't counting that since the migrator still needs to chew through a bunch of dependencies first

@mattip
Copy link
Contributor

mattip commented Jul 19, 2021

Is the migrator still active? At https://conda-forge.org/status/ I see it is listed under "Recently closed migrations" as "pypy37-windows closed at 2021-07-07"

@h-vetinari
Copy link
Member Author

See my comment here

@h-vetinari
Copy link
Member Author

I cannot get the pypy build on PPC to pass despite >5 restarts. Perhaps it needs some of the recent fixes on the pypy-feedstock (and PPC needing manual rebuilds)

@mattip
Copy link
Contributor

mattip commented Jul 21, 2021

I personally would be happy to drop ppc and s390x support for PyPy on conda forge. At least until we get a little more experience around the use case for PyPy on x86/arm64.

@isuruf
Copy link
Member

isuruf commented Jul 22, 2021

travis is supposed to run only a fraction as in https://github.com/conda-forge/scipy-feedstock/blob/master/recipe/run_test.py#L19-L21. Not sure why that doesn't get triggered.

@h-vetinari
Copy link
Member Author

h-vetinari commented Jul 22, 2021

@isuruf, it's not a question of runtime. The build regularly fails with:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

It could just be extreme flakiness on the side of travis, but it could equally be a hang caused by the pypy builds. If you could rebuild the current pypy-recipe for aarch&ppc, we could test that hypothesis. Otherwise, I tend to agree with Matti; PPC is already <0.1% of downlods, and pypy-on-PPC is <0.01% of downloads, cf. #171

@rgommers
Copy link
Contributor

+1 for disabling PyPy on PPC, too niche to be worth even this current effort.

@isuruf
Copy link
Member

isuruf commented Jul 22, 2021

Problem with disabling now is that downstream packages will need to disable that platform manually which I want to avoid.

Maybe we should try cross compiling so that we can move away from Travis-CI. Travis-CI has been extremely flaky lately.
I'll see if I can get cross-python to support PyPy. Might need changes in PyPy.

@h-vetinari
Copy link
Member Author

I've tried cross-compiling in Azure, but that creates ~2000 test suite errors in the test suite (not just for PyPy), see here.

@h-vetinari
Copy link
Member Author

Maybe we should try cross compiling so that we can move away from Travis-CI.

See #179

@h-vetinari
Copy link
Member Author

Unexpectedly, cross-compilation on ppc now works without issue. This will be solved as soon as #182 is merged.

@h-vetinari h-vetinari mentioned this issue Aug 4, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants