-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 missing pypy builds for 1.7.0 #173
Comments
I think the PyPy crash is due to a huge stack allocation when entering a function, cython/cython#4272. I don't understand what the difference is between CPython and PyPy. |
The PPC build will need some encouragement (=restarts), keeping this open until then. |
I think windows64 pypy migration is missing as well? |
Yes indeed, but I wasn't counting that since the migrator still needs to chew through a bunch of dependencies first |
Is the migrator still active? At https://conda-forge.org/status/ I see it is listed under "Recently closed migrations" as "pypy37-windows closed at 2021-07-07" |
See my comment here |
I cannot get the pypy build on PPC to pass despite >5 restarts. Perhaps it needs some of the recent fixes on the pypy-feedstock (and PPC needing manual rebuilds) |
I personally would be happy to drop ppc and s390x support for PyPy on conda forge. At least until we get a little more experience around the use case for PyPy on x86/arm64. |
travis is supposed to run only a fraction as in https://github.com/conda-forge/scipy-feedstock/blob/master/recipe/run_test.py#L19-L21. Not sure why that doesn't get triggered. |
@isuruf, it's not a question of runtime. The build regularly fails with:
It could just be extreme flakiness on the side of travis, but it could equally be a hang caused by the pypy builds. If you could rebuild the current pypy-recipe for aarch&ppc, we could test that hypothesis. Otherwise, I tend to agree with Matti; PPC is already <0.1% of downlods, and pypy-on-PPC is <0.01% of downloads, cf. #171 |
+1 for disabling PyPy on PPC, too niche to be worth even this current effort. |
Problem with disabling now is that downstream packages will need to disable that platform manually which I want to avoid. Maybe we should try cross compiling so that we can move away from Travis-CI. Travis-CI has been extremely flaky lately. |
I've tried cross-compiling in Azure, but that creates ~2000 test suite errors in the test suite (not just for PyPy), see here. |
See #179 |
Unexpectedly, cross-compilation on ppc now works without issue. This will be solved as soon as #182 is merged. |
See discussion in #169, culminating in this comment:
The text was updated successfully, but these errors were encountered: