Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows build #3

Closed
traversaro opened this issue Mar 19, 2024 · 4 comments
Closed

Enable Windows build #3

traversaro opened this issue Mar 19, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@traversaro
Copy link
Contributor

traversaro commented Mar 19, 2024 •
edited
Loading

Comment:

Currently rerun-sdk C++ libraries does not support BUILD_SHARED_LIBS=ON on Windows, we need to do either:
@traversaro traversaro added question Further information is requested enhancement New feature or request and removed question Further information is requested labels Mar 19, 2024
@traversaro
Copy link
Contributor Author

Modify rerun-sdk to support BUILD_SHARED_LIBS=ON on Windows.

Done in rerun-io/rerun#6053 .

@traversaro traversaro mentioned this issue Apr 21, 2024
Merged
5 tasks
@traversaro
Copy link
Contributor Author

Modify rerun-sdk to support BUILD_SHARED_LIBS=ON on Windows.

Done in rerun-io/rerun#6053 .

The PR was merged. As the changes are not trivial, I will not try to backport, let's just wait the next release and then enable Windows there.

@traversaro
Copy link
Contributor Author

Now it should be doable: #8 .

@traversaro
Copy link
Contributor Author

Fixed in #8 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traversaro