Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De]activate scripts not working #1

Closed
jakirkham opened this issue Aug 8, 2016 · 6 comments · Fixed by #3
Closed

[De]activate scripts not working #1

jakirkham opened this issue Aug 8, 2016 · 6 comments · Fixed by #3

Comments

@jakirkham
Copy link
Member

Appears the [de]activate scripts are not working on Linux or Windows. See this CircleCI log or this AppVeyor log for details. @msarahan, any idea what is going on here?

@jakirkham
Copy link
Member Author

Seems like this issue should appear on Mac too.

@jakirkham
Copy link
Member Author

Have added all of these to the broken label and removed the main. This should allow the packages to still be inspected. Though they won't be downloaded by default. It will also avoid having new broken packages get uploaded in their place (i.e. as could happen with removal).

@jakirkham
Copy link
Member Author

Appears there are only symlinks in bin. Guessing we are missing some crucial install step.

@jakirkham jakirkham changed the title [De]activate scripts not working on Linux [De]activate scripts not working Aug 8, 2016
@msarahan
Copy link
Member

msarahan commented Aug 9, 2016

I don't know what's going on here, but my best guess is something like:

  1. conda-build creates the build environment and activates it. This makes the symlinks that you are finding.
  2. During install (build.sh/bld.bat), something should remove or overwrite those with the actual files. Is this happening? Apologies if I am not seeing it, but I think it might be a more manual process than just the python setup.py install.
  3. the always_include_files stuff looks OK to me, but that's another area to double-check.

@jakirkham
Copy link
Member Author

  1. conda-build creates the build environment and activates it. This makes the symlinks that you are finding.

That was what I was thinking. Thanks for confirming.

  1. During install (build.sh/bld.bat), something should remove or overwrite those with the actual files. Is this happening? Apologies if I am not seeing it, but I think it might be a more manual process than just the python setup.py install.

👍 I think this is absolutely right. Was checking for this in the conda repo's recipe, but am not seeing it there either. Though it looks like this is is a simple matter of copying them in from the shell directory.

  1. the always_include_files stuff looks OK to me, but that's another area to double-check.

Ok, will double check this after addressing 2.

@jakirkham
Copy link
Member Author

Maybe PR ( #3 ) will solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants