Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a button + menu component, and use it to show the show/hide pane menu instead of the current approach (again) #6050

Open
bkrmendy opened this issue Jul 9, 2024 · 0 comments
Assignees

Comments

@bkrmendy
Copy link
Contributor

bkrmendy commented Jul 9, 2024

Problem
The current approach (button with checkboxes in the secondary menu) is aw(kward/ful) because it stays open and creates a separate mode that we then need to exit out of.

Solution

  1. Create a button-opens-a-menu component, make sure the menu opens in relative to the button not the mouse (it's not a context menu). Note the button highlight when the menu is open.
  2. Use it instead of the secondary toolbar for the show/hide navigator/inspector/codeeditor menu
  3. For the context menu, use the [checkbox][label][keyboard shortcut] three-column format
  4. Populate it with the current settings and keyboard shortcuts

For clarity, this is the standard pattern that gets used in lots of UIs all over the place, including VSCode itself and Figma

Image

Image

@bkrmendy bkrmendy self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant